[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] virtio-mmio: introduce set_host_notifier()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] virtio-mmio: introduce set_host_notifier() |
|
Date: |
Wed, 06 May 2015 08:52:24 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/06/2015 01:52 AM, Pavel Fedin wrote:
[meta-comment]
> set_host_notifier() is introduced into virtio-mmio now. Most of codes came
> from virtio-pci.
>
Missing an 'In-Reply-To: <address@hidden>'
header, which makes your series unthreaded (every message appeared as
its own thread). It makes review easier if everything is properly
threaded to the cover letter, so you may want to send a series to
yourself first as a test case of your setup before sending to the list.
Other submission hints at: http://wiki.qemu.org/Contribute/SubmitAPatch
>
> +static int virtio_mmio_set_host_notifier_internal(VirtIOMMIOProxy *proxy,
> + int n, bool assign, bool
> set_handler)
Long line, you might want to wrap it to fit in 80 columns.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature