qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix default CPU model for ARM64


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] Fix default CPU model for ARM64
Date: Wed, 6 May 2015 16:50:21 +0100

On 6 May 2015 at 16:03, Pavel Fedin <address@hidden> wrote:
>  This small patch fixes a long-standing bug: A15 model is used by default
> also on ARM64 target. As a result, attempt to run the VM without explicit
> -cpu specification does not do anything good.
>
> Signed-off-by: Pavel Fedin <address@hidden>
> ---
>  hw/arm/virt.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 6a45d94..b064bac 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -785,7 +785,11 @@ static void machvirt_init(MachineState *machine)
>      char **cpustr;
>
>      if (!cpu_model) {
> +#ifdef TARGET_AARCH64
> +        cpu_model = "cortex-a57";
> +#else
>          cpu_model = "cortex-a15";
> +#endif
>      }

I'm afraid this is wrong -- the same command line on
qemu-system-arm and qemu-system-aarch64 should do the same thing.

I agree that the current behaviour is confusing but I don't think
this is the correct way to fix it.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]