[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 param
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 parameters |
Date: |
Wed, 06 May 2015 13:09:29 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/06/2015 11:50 AM, Juan Quintela wrote:
> From: Liang Li <address@hidden>
>
> Put the three parameters related to multiple thread (de)compression
> into an int array, and use an enum type to index the parameter.
>
> Signed-off-by: Liang Li <address@hidden>
> Signed-off-by: Yang Zhang <address@hidden>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> include/migration/migration.h | 4 +---
> migration/migration.c | 31 +++++++++++++++++++------------
> qapi-schema.json | 23 +++++++++++++++++++++++
> 3 files changed, 43 insertions(+), 15 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -569,6 +569,29 @@
> ##
> { 'command': 'query-migrate-capabilities', 'returns':
> ['MigrationCapabilityStatus']}
>
> +# @MigrationParameter
> +#
> +# Migration parameters enumeration
> +#
> +# @compress-level: Set the compression level to be used in live migration,
> +# the compression level is an integer between 0 and 9, where 0 means
> +# no compression, 1 means the best compression speed, and 9 means
> best
> +# compression ratio which will consume more CPU.
> +#
> +# @compress-threads: Set compression thread count to be used in live
> migration,
> +# the compression thread count is an integer between 1 and 255.
> +#
> +# @decompress-threads: Set decompression thread count to be used in live
> +# migration, the decompression thread count is an integer between 1
> +# and 255. Usually, decompression is at least 4 times as fast as
> +# compression, so set the decompress-threads to the number about 1/4
> +# of compress-threads is adequate.
> +#
> +# Since: 2.3
s/2.3/2.4/ (okay as part of the followup patch)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 07/15] migration: Split save_zero_page from ram_save_page, (continued)
- [Qemu-devel] [PULL 07/15] migration: Split save_zero_page from ram_save_page, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 08/15] migration: Add the core code of multi-thread compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 09/15] migration: Make compression co-work with xbzrle, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 10/15] migration: Add the core code for decompression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 11/15] migration: Add interface to control compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 15/15] migration: avoid divide by zero in xbzrle cache miss rate, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 13/15] migration: Add qmp commands to set and query parameters, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 parameters, Juan Quintela, 2015/05/06
- Re: [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 parameters,
Eric Blake <=
- [Qemu-devel] [PULL 14/15] migration: Add hmp interface to set and query parameters, Juan Quintela, 2015/05/06
- Re: [Qemu-devel] [PULL 00/15] migration pull request, Peter Maydell, 2015/05/06