Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

[Peter Maydell]

On 7 May 2015 at 10:29, Shannon Zhao <address@hidden> wrote:
> From: Shannon Zhao <address@hidden>
>
> Add aml_interrupt() for describing device interrupt in resource template.
> These can be used to generating DSDT table for ACPI on ARM.

> +    /* Interrupt Number */
> +    build_append_byte(var->buf, extract32(irq, 0, 8)); /* bits[7:0] */
> +    build_append_byte(var->buf, extract32(irq, 8, 8)); /* bits[15:8] */
> +    build_append_byte(var->buf, extract32(irq, 16, 8)); /* bits[23:16] */
> +    build_append_byte(var->buf, extract32(irq, 24, 8)); /* bits[31:24] */

You used this twice in the previous patch and again here. Can
we factor it out so we can
  build_append_uint32(var->buf, irq);

?

thanks
-- PMM