Re: [Qemu-devel] [PATCH v3] Fixes several full screen issues on Mac OS X

[Programmingkid]

On May 10, 2015, at 3:13 PM, Peter Maydell wrote:

> On 21 January 2015 at 19:25, Programmingkid <address@hidden> wrote:
>> This patch makes several changes:
>> - Minimizes distorted full screen display by respecting aspect
>> ratios.
>> - Makes full screen mode available on Mac OS 10.7 and higher.
>> - Allows user to decide if video should be stretched to fill the
>> screen, using a menu item called "Zoom To Fit".
>> - Hides the normalWindow so it won't show up in full screen mode.
>> - Allows user to exit full screen mode.
>> 
>> Signed-off-by: John Arbuckle <address@hidden>
>> 
>> ---
>> Changes in version 2:
>> - Completely rewritten.
>> - Eliminated depreciated API's.
>> - Does not change host monitor resolution.
>> 
>> Change in version 3:
>> - Fixed full screen window not receiving mouse moved events.
>> @@ -1005,7 +1043,8 @@ int main (int argc, const char * argv[]) {
>> 
>>     // View menu
>>     menu = [[NSMenu alloc] initWithTitle:@"View"];
>> -    [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"Enter Fullscreen" 
>> action:@selector(toggleFullScreen:) keyEquivalent:@"f"] autorelease]]; // 
>> Fullscreen
>> +    [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"Enter Fullscreen" 
>> action:@selector(doToggleFullScreen:) keyEquivalent:@"f"] autorelease]]; // 
>> Fullscreen
>> +    [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"Zoom To Fit" 
>> action:@selector(zoomToFit:) keyEquivalent:@"f"] autorelease]];
> 
> This creates two menu items with the same keyEquivalent, which
> looks like a cut and paste error? It doesn't seem to me like
> we need an accelerator for zoom-to-fit, so we can just make
> that @"" instead I think.
> 
> Unless you'd rather do something else, I'm going to apply this
> patch to my cocoa queue with that change and a couple of other
> minor whitespace-formatting tweaks.
> 
> (Looking again at whether zoom-to-fit should be default,
> I think I must have been deceived by the 1400x900 builtin
> MBA screen being a nice multiple of the VGA screen size;
> doing full-screen-zoomed on my other monitor looks much
> worse. So I'm leaving that as you wrote it.)
> 
> Sorry it's taken me so long to get back to this.
> 
> thanks
> -- PMM

Thank you for reviewing my patch and correcting the double command-f shortcut 
mistake.