qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor
Date: Sun, 10 May 2015 23:51:12 +0100

On 10 May 2015 at 23:34, Peter Maydell <address@hidden> wrote:
> I've now tested again with my not-just-the-laptop setup, and:
>
>  * in the guest OS (I tested with a Linux guest), PageUp/Down
>    work OK and work the same whether I use an external USB
>    keyboard with a physical PgUp/Down key or the MacBook Air's
>    keyboard with Fn+UpArrow/Fn+DownArrow as the chord to
>    input pageup/down
>  * in the monitor window, neither way of inputting PageUp/Down
>    works: all you get is a ',' input into the monitor
>
> So my conclusion is that we should fix the underlying
> problem that the monitor isn't handling PgUp/PgDown
> correctly (not sure exactly why that's not working yet).

So looking at the code in ui/console.c that implements our
virtual consoles, the scrolling is hooked up to the keycodes
QEMU_KEY_CTRL_{UP,DOWN,PAGEUP,PAGEDOWN}. These only seem
to be output by one of our UI frontends, SDL.

Gerd, how is this supposed to work? Shouldn't something
in the generic console code be handling converting the
Q_KEY_CODE_CTRL/CTRL_R + Q_KEY_CODE_PGUP/DOWN/etc into
what the vc layer expects, rather than having each of the
ui frontends doing it?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]