Re: [Qemu-devel] [RFC 4/5] tcg-op: create new TCG qemu_ldlink and qemu_stcond instructions

[alvise rigo]

On Thu, May 7, 2015 at 7:58 PM, Richard Henderson <address@hidden> wrote:
> On 05/06/2015 08:38 AM, Alvise Rigo wrote:
>> +/* An output operand to return the StoreConditional result */
>> +static void gen_stcond_i32(TCGOpcode opc, TCGv_i32 is_dirty, TCGv_i32 val,
>> +                         TCGv addr, TCGMemOp memop, TCGArg idx)
>> +{
>> +    tcg_gen_op5ii_i32(opc, is_dirty, val, addr, memop, idx);
>> +}
>
> This is the wrong way to go about this.  I think you should merely add an EXCL
> bit to TCGMemOp, and add no new opcodes at all.

You are right, there is no need of a new opcode here.

Thank you,
alvise

>
>
> r~