Re: [Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property

[Cornelia Huck]

On Mon, 11 May 2015 17:34:04 +0800
address@hidden wrote:

> From: Shannon Zhao <address@hidden>
> 
> The wrappers of virtio-balloon are using object_property_add to add
> properties and all have their own getters/setters which are duplicate of
> those in virtio-balloon device. So this patchset uses
> object_property_add_alias for these properties as Paolo suggested.
> 
> Shannon Zhao (3):
>   hw/virtio/virtio-balloon: move adding property to
>     virtio_balloon_instance_init
>   hw/virtio/virtio-pci: use alias property for virtio-balloon-pci
>   hw/s390x/virtio-ccw: use alias property for virtio-balloon-ccw
> 
>  hw/s390x/virtio-ccw.c      | 39 ++++++---------------------------------
>  hw/virtio/virtio-balloon.c | 22 ++++++++++++++--------
>  hw/virtio/virtio-pci.c     | 40 ++++++----------------------------------
>  3 files changed, 26 insertions(+), 75 deletions(-)
> 

Looks good, and seems to work fine on s390x.

Reviewed-by: Cornelia Huck <address@hidden>