[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View m
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu |
|
Date: |
Mon, 11 May 2015 15:33:13 +0100 |
On 11 May 2015 at 15:29, Programmingkid <address@hidden> wrote:
>
> On May 11, 2015, at 9:20 AM, Peter Maydell wrote:
>> Can't we just create a menu with an item for every console,
>> and set its menu text to the result of qemu_console_get_label() ?
>> I don't see why we need to special case these four and only
>> display those.
> We *could* do it that way, but it wouldn't look pretty. Instead of having
> these menu items:
>
> VGA, Monitor, Serial, Parallel
>
> We would have these menu items:
>
> VGA
> compat_monitor0
> serial0
> parallel0
>
> They look very anti-pretty.
They're the menu entries we have in the GTK UI. If you want
pretty names then you should fix this in the common code
so that any UI that wants to display pretty names can do
that. Having the OSX UI do things differently is not a
good idea.
-- PMM