[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup |
Date: |
Mon, 11 May 2015 08:50:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/11/2015 07:46 AM, Paolo Bonzini wrote:
>
>
> On 09/05/2015 22:11, Peter Crosthwaite wrote:
>> @@ -198,6 +199,8 @@ static int print_insn_od_target(bfd_vma pc,
>> disassemble_info *info)
>> void target_disas(FILE *out, CPUArchState *env, target_ulong code,
>> target_ulong size, int flags)
>> {
>> + CPUState *cpu = ENV_GET_CPU(env);
>> + CPUClass *cc = CPU_GET_CLASS(cpu);
>> target_ulong pc;
>> int count;
>> CPUDebug s;
>> @@ -215,6 +218,11 @@ void target_disas(FILE *out, CPUArchState *env,
>> target_ulong code,
>> #else
>> s.info.endian = BFD_ENDIAN_LITTLE;
>> #endif
>> +
>> + if (cc->disas_set_info) {
>> + cc->disas_set_info(cpu, &s.info);
>> + }
>> +
>> #if defined(TARGET_I386)
>
> Perhaps pass down the flags too?
The hook is allowing us to ditch the flags. See 4/7 and 7/7 for arm and cris
portions that do exactly that.
r~
- [Qemu-devel] [PATCH v2 0/7] Unify and QOMify (target|monitor)_disas, Peter Crosthwaite, 2015/05/09
- [Qemu-devel] [PATCH v2 1/7] disas: Add print_insn to disassemble info, Peter Crosthwaite, 2015/05/09
- [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup, Peter Crosthwaite, 2015/05/09
- [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable, Peter Crosthwaite, 2015/05/09
- [Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup, Peter Crosthwaite, 2015/05/09
- [Qemu-devel] [PATCH v2 5/7] disas: microblaze: QOMify target specific disas setup, Peter Crosthwaite, 2015/05/09
- [Qemu-devel] [PATCH v2 6/7] disas: cris: Fix 0 buffer length case, Peter Crosthwaite, 2015/05/09
- [Qemu-devel] [PATCH v2 7/7] disas: cris: QOMify target specific disas setup, Peter Crosthwaite, 2015/05/09