[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOC
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT |
|
Date: |
Mon, 11 May 2015 10:52:22 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/08/2015 02:10 PM, Eric Blake wrote:
> On 05/08/2015 11:47 AM, Dimitris Aragiorgis wrote:
>> Building the QEMU tools fails if we #define DEBUG_BLOCK inside
>> block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
>> so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
>> a simple DPRINTF().
>>
> Please fix this to ensure that we avoid bit-rot even when debugging is
> not turned on. Something like:
>
> #ifdef DEBUG_BLOCK
> # define DEBUG_BLOCK_PRINT 1
> #else
> # define DEBUG_BLOCK_PRINT 0
> #endif
> #define DPRINTF(fmt, ...) \
> do \
> if (DEBUG_BLOCK_PRINT) { \
> printf(fmt, ## __VA_ARGS__); \
> while (0)
Obviously, with the missing } that allows compilation :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic, Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT, Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 5/5] raw-posix: Introduce hdev_is_sg(), Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY, Dimitris Aragiorgis, 2015/05/08
- [Qemu-devel] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere, Dimitris Aragiorgis, 2015/05/08
- Re: [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic, Paolo Bonzini, 2015/05/10