Re: [Qemu-devel] [Xen-devel] [PATCH v6 2/6] Qemu-Xen-vTPM: Xen frontend driver infrastructure

[Stefano Stabellini]

On Tue, 12 May 2015, Xu, Quan wrote:
> > -----Original Message-----
> > From: address@hidden
> > [mailto:address@hidden On Behalf Of Stefano Stabellini
> > Sent: Friday, May 08, 2015 1:26 AM
> > To: Xu, Quan
> > Cc: address@hidden; address@hidden;
> > address@hidden; address@hidden;
> > address@hidden; address@hidden; address@hidden
> > Subject: Re: [Xen-devel] [PATCH v6 2/6] Qemu-Xen-vTPM: Xen frontend driver
> > infrastructure
> > 
> > On Mon, 4 May 2015, Quan Xu wrote:
> > > This patch adds infrastructure for xen front drivers living in qemu,
> > > so drivers don't need to implement common stuff on their own.  It's
> > > mostly xenbus management stuff: some functions to access XenStore,
> > > setting up XenStore watches, callbacks on device discovery and state
> > > changes, and handle event channel between the virtual machines.
> > >
> > > Call xen_fe_register() function to register XenDevOps, and make sure,
> > > XenDevOps's flags is DEVOPS_FLAG_FE, which is flag bit to point out
> > > the XenDevOps is Xen frontend.
> > >
> > > Create a new file xen_pvdev.c for some common part of xen frontend and
> > > backend, such as xendevs queue and xenstore update functions.
> > >
> > > Signed-off-by: Quan Xu <address@hidden>
> > 
> > Better than the early versions, thanks.
> > 
> > However the patch is too big and it is too difficult to read as is.
> > Could you please split it in two: a patch that creates xen_pvdev.c and 
> > moves a
> > few functions from xen_backend.c to it and a second patch that introduces
> > xen_frontend.c.
> > 
> 
> Stefano,
>        I missed this comment. Sorry for that.
>        Agreed, also I think it is too big. I will do it in v8. 

Thanks! If you could also try to address the other comments on this
patch in v8, that would be great.