qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions
Date: Tue, 12 May 2015 22:42:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/12/2015 10:27 PM, Richard Henderson wrote:
On 05/12/2015 01:20 PM, Alexander Graf wrote:
+static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
+{
+    /* XXX should reserve the address */
+    in2_m2_32s(s, f, o);
+}
+#define SPEC_in2_m2_32s_atomic 0
+
+static void in2_m2_64_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
+{
+    /* XXX should reserve the address */
+    in2_m2_64(s, f, o);
+}
+#define SPEC_in2_m2_64_atomic 0
+
I think these should save the address in o->addr1 so that you don't have to
recompute it in the wout functions.

But wouldn't it really be "addr2"? This is the address source for the second argument after all.


Alex


Otherwise I think this is a great scheme, making it easy to implement this
whole family of instructions.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]