[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure |
Date: |
Tue, 12 May 2015 14:57:03 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> On return, either all new options should be applied to BDRVQcowState (on
> success), or all of the old setting should be preserved (on failure).
s/setting/settings/
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 52 ++++++++++++++++++++++++++++++++--------------------
> 1 file changed, 32 insertions(+), 20 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 20/34] qcow2: Support updating driver-specific options in reopen, (continued)
- [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 21/34] block: Consider all block layer options in append_open_options, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 22/34] block: Exclude nested options only for children in append_open_options(), Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 23/34] block: Pass driver-specific options to .bdrv_refresh_filename(), Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 25/34] block: Allow specifying child options in reopen, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 26/34] block: reopen: Document option precedence and refactor accordingly, Kevin Wolf, 2015/05/08