[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500
From: |
Pavel Fedin |
Subject: |
Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500 |
Date: |
Wed, 13 May 2015 16:57:18 +0300 |
Hello!
> 1. In fdt_add_timer why you didn't used the 24 bit limit I posed on the
> irqflags? Please
note that
> the argument is 32 bits wide and 8 bits are for flags.
Simply missed it when checking for differences. Please fix. :) Perhaps it is
the reason
why >=24 CPUs fail for you.
> 2. In machvirt_init, I used TYPE_AARCH64_CPU while you reverted it to
> TYPE_ARM_CPU, I
> assume this is because you want to support cortex-a15. Don't you think It
> should be
according
> to the cortex type?
Yes, i just left it as it was because it already works fine with ARM64.
Actually,
TYPE_AARCH64_CPU is a subclass of TYPE_ARM_CPU.
> (BTW you removed cortex-a53).
Yes, because i didn't see how it is different from a57 (or a15). I tried to
follow
minimal intervention principle.
But perhaps i was wrong because there was real support for a53 added recently:
http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg01304.html, so feel
free to
re-add it back.
BTW, just for interest, have you tried to do anything with KVM support of
vGICv3? I have
some code but it's inherently unstable and lock up for unknown (yet) reason.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
- [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/05/08
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Shlomo Pongratz, 2015/05/11
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/05/12
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Shlomo Pongratz, 2015/05/12
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/05/12
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Shlomo Pongratz, 2015/05/13
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500,
Pavel Fedin <=
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Shlomo Pongratz, 2015/05/14
- Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/05/14
Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Pavel Fedin, 2015/05/12
Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500, Daniel P. Berrange, 2015/05/12