[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults |
Date: |
Wed, 13 May 2015 18:29:46 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
Do not emulate a floppy drive if no drives are supposed to be present.
This fixes the behavior of -nodefaults, that should remove the floppy
drive (see docs/qdev-device-use.txt:Default Devices), but actually
doesn't.
Signed-off-by: Stefano Stabellini <address@hidden>
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index a8e6be1..c9f50b3 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1410,6 +1410,7 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
qemu_irq *cpu_exit_irq;
MemoryRegion *ioport80_io = g_new(MemoryRegion, 1);
MemoryRegion *ioportF0_io = g_new(MemoryRegion, 1);
+ bool floppy_exist;
memory_region_init_io(ioport80_io, NULL, &ioport80_io_ops, NULL,
"ioport80", 1);
memory_region_add_subregion(isa_bus->address_space_io, 0x80, ioport80_io);
@@ -1487,10 +1488,17 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq
*gsi,
cpu_exit_irq = qemu_allocate_irqs(cpu_request_exit, NULL, 1);
DMA_init(0, cpu_exit_irq);
+ *floppy = NULL;
+ floppy_exist = false;
for(i = 0; i < MAX_FD; i++) {
fd[i] = drive_get(IF_FLOPPY, 0, i);
+ if (fd[i] != NULL) {
+ floppy_exist = true;
+ }
+ }
+ if (floppy_exist) {
+ *floppy = fdctrl_init_isa(isa_bus, fd);
}
- *floppy = fdctrl_init_isa(isa_bus, fd);
}
void pc_nic_init(ISABus *isa_bus, PCIBus *pci_bus)
- [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults,
Stefano Stabellini <=
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Daniel P. Berrange, 2015/05/13
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Stefano Stabellini, 2015/05/13
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, John Snow, 2015/05/13
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Stefano Stabellini, 2015/05/14
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Daniel P. Berrange, 2015/05/14
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Michael S. Tsirkin, 2015/05/14
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Markus Armbruster, 2015/05/14
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Paolo Bonzini, 2015/05/14
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Markus Armbruster, 2015/05/14
- Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults, Daniel P. Berrange, 2015/05/14