[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mirror: correct buf_size
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] mirror: correct buf_size |
|
Date: |
Thu, 14 May 2015 12:20:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 14/05/2015 12:07, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> ---
> block/mirror.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 58f391a..bb6bc27 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -686,6 +686,10 @@ static void mirror_start_job(BlockDriverState *bs,
> BlockDriverState *target,
> s->granularity = granularity;
> s->buf_size = MAX(buf_size, granularity);
>
> + if (s->buf_size % granularity != 0) {
> + s->buf_size = ROUND_UP(s->buf_size, granularity);
> + }
> +
Good catch! But I think the "if" is not needed, and also this removes
the need for the s->buf_size assignment before.
The ROUND_UP is really the only thing that is needed.
Paolo