[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop d
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling |
Date: |
Thu, 14 May 2015 10:48:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/12/2015 06:02 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> net/tap.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> @@ -552,14 +551,8 @@ int net_init_bridge(const NetClientOptions *opts, const
> char *name,
> }
>
> fcntl(fd, F_SETFL, O_NONBLOCK);
Well, fcntl() could fail. And don't we have the helper function
util/oslib-posix.c:qemu_set_nonblock() for doing this correctly? (Then
again, that helper also ignores failures).
But the raw use of fcntl here is pre-existing and you didn't touch it,
so it doesn't affect my review of this patch.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/15] net: Improve error reporting, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 04/15] net/dump: Improve -net/host_net_add dump error reporting, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 03/15] net: Improve -net nic error reporting, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 07/15] tap: Convert tap_set_sndbuf() to Error, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling, Markus Armbruster, 2015/05/12
- Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling,
Eric Blake <=
- [Qemu-devel] [PATCH 06/15] tap: Improve -netdev/netdev_add/-net/... bridge error reporting, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 11/15] tap-linux: Convert tap_open() to Error, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 10/15] tap: Permit incremental conversion of tap_open() to Error, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 12/15] tap-bsd: Convert tap_open() to Error, Markus Armbruster, 2015/05/12