qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions
Date: Fri, 15 May 2015 10:01:01 -0700

On Fri, May 15, 2015 at 6:36 AM, Richard Henderson <address@hidden> wrote:
> On 05/15/2015 03:59 AM, Andreas Färber wrote:
>> I would prefer 1. independent of whether we rename them or not. We need
>> a better distinction of internal vs. external for targets.
>
> +1.
>

Ok, Plan 1 wins. There is some devil in the detail on the how. We will
need a second header much like cpu.h that:

1: Is visible to target-foo/*.c
2: Is visible to user-mode core code (alternative is to move
target-specific #ifdef user-mode code to arch specific files).
linux-user/main.c at least.

RFC for where and what to name it and general guidelines on what
content to include. Some options:

cpu-user.h
cpu-foo.h
foo.h
cpu-core.h
core.h
internals.h

Regards,
Peter

>
> r~
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]