[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun |
|
Date: |
Mon, 18 May 2015 06:56:58 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/18/2015 06:54 AM, Eric Blake wrote:
> On 05/17/2015 10:00 AM, address@hidden wrote:
>> Subject: [PATCH] keyboard: handle ps2 typing buffer overrun
>
> This line is redundant.
>
> Also, you have tried to send this patch more than once. Please be sure
> to include a proper 'v3' or 'v4' in the subject line, as appropriate.
>
>> Starting a linux guest with ps2 keyboard, if you type many times during
>> leaving
>> grub and into linux kernel,then you can't use keyboard after linux
>> initialization finished.
>> Specally when you setup linux guest from iso file,you will type in grub.
>
> s/Specally/Specifically,/
> s/file,you/file, you/
In fact, I called these out on your v2 submission.
https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00938.html
Sending a v3 without addressing points made in v2 is not good - it
wastes everyone's time, and makes it more likely that your patch will be
intentionally overlooked.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature