[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store |
Date: |
Mon, 18 May 2015 08:50:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/18/2015 04:38 AM, Denis V. Lunev wrote:
> On 14/05/15 19:28, Juan Quintela wrote:
>> This allows us to store the current state to send it through migration.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> + if (strlen(state)+1 > size) {
>> + return -1;
>> + }
>> + strncpy(str, state, strlen(state)+1);
>> + return 0;
>> +}
>> +
>> static void runstate_init(void)
>> {
>> const RunStateTransition *p;
>>
>
> minor. why to call strlen() twice?
Also, why no spaces around binary '+'?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] Optional toplevel sections, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 3/9] runstate: Add runstate store, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 5/9] runstate: migration allows more transitions now, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 1/9] migration: create savevm_state, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 6/9] migration: create new section to store global state, Juan Quintela, 2015/05/14
- [Qemu-devel] [PATCH 7/9] global_state: Make section optional, Juan Quintela, 2015/05/14