[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big |
|
Date: |
Mon, 18 May 2015 16:51:06 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.05.2015 um 10:36 hat Fam Zheng geschrieben:
> v2: Correct detection of overflow. [Markus, Berto]
>
> If the image has a huge enough virtual size,
>
> $ qemu-img info afl9.img
> qemu-img: Can't get size of device 'image': Unknown error -512
>
> It's because of the multiplication overflow in the return statement in
> bdrv_getlength (the big nagetive value is later truncated to 0x200). Fix it to
> return -EFBIG:
>
> qemu-img: Can't get size of device 'image': File too large
>
> Bug reported by Richard Jones in:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1221499
Thanks, applied to the block branch.
Kevin