[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callba
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support |
|
Date: |
Mon, 18 May 2015 16:48:46 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, May 11, 2015 at 07:04:24PM -0400, John Snow wrote:
> @@ -1825,6 +1827,19 @@ static void drive_backup_prepare(BlkActionState
> *common, Error **errp)
> }
> bs = blk_bs(blk);
>
> + /* BackupBlockJob is opaque to us, so look up the bitmap ourselves */
> + if (backup->has_bitmap) {
> + bmap = bdrv_find_dirty_bitmap(bs, backup->bitmap);
This usage of bs needs to be inside aio_context_acquire().
pgp8DzmqytISK.pgp
Description: PGP signature
- Re: [Qemu-devel] [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps, (continued)
- [Qemu-devel] [PATCH v4 07/11] block: add delayed bitmap successor cleanup, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 05/11] block: add transactional callbacks feature, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 10/11] iotests: 124 - transactional failure test, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations, John Snow, 2015/05/11