Re: [Qemu-devel] [PATCH 3/4] rocker: bring link up/down on PHY enable/disable

[Stefan Hajnoczi]

On Wed, May 13, 2015 at 11:06:53PM -0700, address@hidden wrote:
> From: Scott Feldman <address@hidden>
> 
> When the OS driver enables/disables the port, go ahead and set the port's
> link status to up/down in response to the change.  This more closely
> emulates real hardware when the PHY for the port is brought up/down
> and the PHY negotiates carrier (link status) with link partner.  In
> the case of qemu, the virtual rocker device can't really do link
> negotiation with the link partner as that requires signally over a
> physical medium (the wire), so just pretend the negotiation was
> successful and bring the link up when the port is enabled.
> 
> Signed-off-by: Scott Feldman <address@hidden>
> ---
>  hw/net/rocker/rocker_fp.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpKdSJQeBKVA.pgp
Description: PGP signature