qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] scripts: qom-*: add network syntax


From: Martin Cerveny
Subject: Re: [Qemu-devel] [PATCH 1/2] scripts: qom-*: add network syntax
Date: Tue, 19 May 2015 16:12:15 +0200 (CEST)
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)

Hello.

On Tue, 19 May 2015, Eric Blake wrote:
On 05/19/2015 06:51 AM, Andreas Färber wrote:
Am 13.05.2015 um 14:14 schrieb Martin Cerveny:
Add network syntax parsing (ip address, port) to qom-* scripts.

Signed-off-by: Martin Cerveny <address@hidden>
---
 scripts/qmp/qom-fuse |   13 ++++++++++++-
 scripts/qmp/qom-get  |   12 +++++++++++-
 scripts/qmp/qom-list |   12 +++++++++++-
 scripts/qmp/qom-set  |   12 +++++++++++-
 scripts/qmp/qom-tree |   12 +++++++++++-
 5 files changed, 56 insertions(+), 5 deletions(-)

Could some Python guru please take a look at this?

That disqualifies me (still a python newbie), but I still see something
questionable:


-srv = QEMUMonitorProtocol(socket_path)
+connection = socket_path.split(':')
+if len(connection) == 2:
+    try:
+         port = int(connection[1])
+    except ValueError:
+         raise QMPBadPort
+    connection = ( connection[0], port )

Won't that mishandle IPv6 connections, such as something like [::1]:8000
for connecting to port 8000 on localhost, since it splits into more than
2 pieces when splitting on :?

Yes, this is problem, but I copy-paste the same construct from scripts/qmp/qmp-shell to be compatible.
Is the IPv6 support for utilities mandatory ?
If yes I can make V2.

M.C>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]