[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/5] vnc: Tweak error when init fails
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/5] vnc: Tweak error when init fails |
Date: |
Wed, 20 May 2015 10:34:12 +0200 |
From: Cole Robinson <address@hidden>
Before:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC
server on `(null)': Failed to bind socket to /root/foo.sock: Permission denied
After:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC
server: Failed to bind socket to /root/foo.sock: Permission denied
Rather than tweak the string possibly show unix: value as well,
just drop the explicit display reporting. We already get the cli
string in the error message, that should be sufficient.
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index fe4cd75..1013ea5 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3779,8 +3779,7 @@ int vnc_init_func(QemuOpts *opts, void *opaque)
vnc_display_init(id);
vnc_display_open(id, &local_err);
if (local_err != NULL) {
- error_report("Failed to start VNC server on `%s': %s",
- qemu_opt_get(opts, "display"),
+ error_report("Failed to start VNC server: %s",
error_get_pretty(local_err));
error_free(local_err);
exit(1);
--
1.8.3.1
- [Qemu-devel] [PULL 0/5] vnc patch queue, Gerd Hoffmann, 2015/05/20
- [Qemu-devel] [PULL 4/5] vnc: Tweak error when init fails,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 3/5] vnc: Don't assert if opening unix socket fails, Gerd Hoffmann, 2015/05/20
- [Qemu-devel] [PULL 2/5] ui: remove check for failure of qemu_acl_init(), Gerd Hoffmann, 2015/05/20
- [Qemu-devel] [PULL 5/5] qemu-sockets: Report explicit error if unlink fails, Gerd Hoffmann, 2015/05/20
- [Qemu-devel] [PULL 1/5] Strip brackets from vnc host, Gerd Hoffmann, 2015/05/20
- Re: [Qemu-devel] [PULL 0/5] vnc patch queue, Peter Maydell, 2015/05/21