[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config ar
From: |
Leon Alrae |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument |
Date: |
Wed, 20 May 2015 09:51:18 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 20/05/2015 09:30, Liviu Ionescu wrote:
>
>> On 20 May 2015, at 11:11, Leon Alrae <address@hidden> wrote:
>>
>> like "If both are specified, -kernel/-append are ignored (-kernel is
>> used to load an image, but the path won't be passed to semihosting)"
> ...
>> We could initialize semihosting.argv[0] with -kernel
>
>
> here you have a small contradiction, both in the current ARM implementation,
> and in your proposal, the full kernel path is passed as argv[0].
These are two different cases:
1) If both "--semihosting-config arg" and -kernel/-append are specified
in QEMU command line, then -kernel/-append is ignored and
semihosting.argv[0] is set with first arg string instead of -kernel
path, arg[1] with second arg, and so on.
2) If we are in semihosting mode but no "--semihosting-config arg" were
specified then argv[0] is set with full path from -kernel, and argv[1]
is set with -append. This is compatible with what ARM is currently doing
I believe.
The following example would support above two cases arm-semi.c:
- pstrcpy(output_buffer, output_size,
ts->boot_info->kernel_filename);
- pstrcat(output_buffer, output_size, " ");
- pstrcat(output_buffer, output_size,
ts->boot_info->kernel_cmdline);
+ if (semihosting_get_argc()) {
+ pstrcat(output_buffer, output_size,
semihosting_get_arg(0));
+ for (i = 1; i < semihosting_get_argc(); i++) {
+ pstrcat(output_buffer, output_size, " ");
+ pstrcat(output_buffer, output_size,
semihosting_get_arg(i));
+ }
+ }
Leon
- [Qemu-devel] [PATCH v3 0/2] semihosting: clean up and add --semihosting-config arg, Leon Alrae, 2015/05/08
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Peter Maydell, 2015/05/20
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Leon Alrae, 2015/05/20
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Liviu Ionescu, 2015/05/20
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Peter Maydell, 2015/05/20
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Liviu Ionescu, 2015/05/20
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Peter Maydell, 2015/05/20
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Liviu Ionescu, 2015/05/20
- Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument, Peter Maydell, 2015/05/20