[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/12] qom: strdup() target property name on object_p
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL 01/12] qom: strdup() target property name on object_property_add_alias() |
Date: |
Wed, 20 May 2015 17:51:35 +0200 |
From: Eduardo Habkost <address@hidden>
With this, object_property_add_alias() callers can safely free the
target property name, like what already happens with the 'name' argument
to all object_property_add*() functions.
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
qom/object.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index b8dff43..550dd48 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1689,7 +1689,7 @@ void object_property_add_uint64_ptr(Object *obj, const
char *name,
typedef struct {
Object *target_obj;
- const char *target_name;
+ char *target_name;
} AliasProperty;
static void property_get_alias(Object *obj, struct Visitor *v, void *opaque,
@@ -1720,6 +1720,7 @@ static void property_release_alias(Object *obj, const
char *name, void *opaque)
{
AliasProperty *prop = opaque;
+ g_free(prop->target_name);
g_free(prop);
}
@@ -1747,7 +1748,7 @@ void object_property_add_alias(Object *obj, const char
*name,
prop = g_malloc(sizeof(*prop));
prop->target_obj = target_obj;
- prop->target_name = target_name;
+ prop->target_name = g_strdup(target_name);
op = object_property_add(obj, name, prop_type,
property_get_alias,
--
2.1.4
- [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 05/12] backends: Fix typename of 'policy' enum property in hostmem obj, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 02/12] qdev: Free property names after registering gpio aliases, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 10/12] qom: Make enum string tables const-correct, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 12/12] qom: Add object_property_add_const_link(), Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 04/12] scripts: Add support for path as argument of qom-tree, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 01/12] qom: strdup() target property name on object_property_add_alias(),
Andreas Färber <=
- [Qemu-devel] [PULL 08/12] qom: Add helper method for getting user objects root, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 11/12] qom: Add an object_property_add_enum() helper function, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 09/12] qom: Add object_new_with_props() / object_new_withpropv() helpers, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 03/12] tests: Use qtest_add_data_func() consistently, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 06/12] doc: Document user creatable object types in help text, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 07/12] vl: Create (most) objects before creating chardev backends, Andreas Färber, 2015/05/20
- Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20, Peter Maydell, 2015/05/21