Re: [Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add

[Eric Blake]

On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> All QMP commands use the "new" handler interface (mhandler.cmd_new).
> Most HMP commands still use the traditional interface (mhandler.cmd),
> but a few use the "new" one.  Complicates handle_user_command() for no
> gain, so I'm converting these to the traditional interface.
> 
> For device_add, that's easy: just wrap the obvious hmp_device_add()
> around do_device_add().
> 
> monitor_user_noop() is now unused, drop it.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hmp-commands.hx | 3 +--
>  hmp.c           | 6 ++++++
>  hmp.h           | 1 +
>  monitor.c       | 2 --
>  4 files changed, 8 insertions(+), 4 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature