[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool in_command_mode |
|
Date: |
Fri, 22 May 2015 16:56:36 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
Might be worth mentioning in the commit message that...
>
> -static inline int qmp_cmd_mode(const Monitor *mon)
> -{
> - return mon->qmp.command_mode;
> -}
...qmp_cmd_mode() is now inlined into its callers.
Nice, fixes up a mis-use of 'int' that I complained about when writing
commit 2d5a8346
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 14/20] monitor: Rename handle_user_command() to handle_hmp_command(), (continued)
- [Qemu-devel] [PATCH 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 01/20] monitor: Drop broken, unused asynchronous command interface, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 09/20] monitor: Propagate errors through qmp_check_client_args(), Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool in_command_mode, Markus Armbruster, 2015/05/22
- Re: [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool in_command_mode,
Eric Blake <=
- [Qemu-devel] [PATCH 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp(), Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 13/20] monitor: Limit QError use to command handlers, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 16/20] monitor: Unbox Monitor member mc and rename to qmp, Markus Armbruster, 2015/05/22
- [Qemu-devel] [PATCH 11/20] monitor: Wean monitor_protocol_emitter() off mon->error, Markus Armbruster, 2015/05/22