Re: [Qemu-devel] [PATCH RFC 2/4] Set kernel_irqchip_type for other ARM boards which use GIC

[Pavel Fedin]

 Hello!

> > +++ b/hw/arm/exynos4_boards.c
> > @@ -104,6 +104,7 @@ static Exynos4210State
> *exynos4_boards_init_common(MachineState *machine,
> >                  exynos4_machines[board_type].max_cpus);
> >      }
> >
> > +    machine->kernel_irqchip_type = KVM_DEV_TYPE_ARM_VGIC_V2;
> Are you sure this machine is able to use in-kernel GICv2?

 I'm not. I just scanned all machine sources for "GIC" string and added this 
wherever it
was found. Actually it is harmless. If the machine cannot use in-kernel VGIC, 
it will just
not use it.
 Ok, i will know this for the future. Actually i would like to wait for 
Shlomo's patch
integration, because otherwise i violate the main rule "the patchset should 
apply to
current master", and i believe it's not good to specify that "this patches 
applies on top
of YYY one".

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia