[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription |
|
Date: |
Mon, 25 May 2015 19:50:32 +0100 |
On 25 May 2015 at 19:46, Peter Crosthwaite <address@hidden> wrote:
> On Mon, May 25, 2015 at 11:30 AM, Peter Maydell
> <address@hidden> wrote:
>> In looking at this I found that we currently have:
>> CPUs that set cc->vmsd: arm, i386, lm32, mips, moxie, ppc, s390x
>> CPUs that set dc->vmsd: alpha, m68k, microblaze, openrisc, sh4,
>> unicore32, xtensa
>> ...an exactly even split.
>>
>> Which of these is the recommended approach for new conversions?
>
> Should it be DC? CPU should not have specific support for something
> that already works for TYPE_DEVICE. This seems similar to
> SysBusDevice::init where we progressively pushed everything up to the
> higher level over time.
I'm tempted to agree with that, except that all of the CPU
families I'd trust as "major, actively maintained" are in
the "set cc->vmsd" camp...
-- PMM