Re: [Qemu-devel] [PATCH V7 02/24] acpi: add aml_add() term

[Shannon Zhao]

On 2015/5/25 23:33, Marcel Apfelbaum wrote:
> Add encoding for ACPI DefAdd Opcode.
> 
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Shannon Zhao <address@hidden>

> ---
>  hw/acpi/aml-build.c         | 10 ++++++++++
>  include/hw/acpi/aml-build.h |  1 +
>  2 files changed, 11 insertions(+)
> 
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 6a50f37..a823144 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -464,6 +464,16 @@ Aml *aml_or(Aml *arg1, Aml *arg2)
>      return var;
>  }
>  
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefAdd */
> +Aml *aml_add(Aml *arg1, Aml *arg2)
> +{
> +    Aml *var = aml_opcode(0x72 /* AddOp */);
> +    aml_append(var, arg1);
> +    aml_append(var, arg2);
> +    build_append_byte(var->buf, 0x00 /* NullNameOp */);
> +    return var;
> +}
> +
>  /* ACPI 1.0b: 16.2.5.3 Type 1 Opcodes Encoding: DefNotify */
>  Aml *aml_notify(Aml *arg1, Aml *arg2)
>  {
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index b8092f4..58c4c29 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -164,6 +164,7 @@ Aml *aml_arg(int pos);
>  Aml *aml_store(Aml *val, Aml *target);
>  Aml *aml_and(Aml *arg1, Aml *arg2);
>  Aml *aml_or(Aml *arg1, Aml *arg2);
> +Aml *aml_add(Aml *arg1, Aml *arg2);
>  Aml *aml_notify(Aml *arg1, Aml *arg2);
>  Aml *aml_call1(const char *method, Aml *arg1);
>  Aml *aml_call2(const char *method, Aml *arg1, Aml *arg2);
> 

-- 
Shannon