Re: [Qemu-devel] [PATCH 06/29] memory: prepare for multiple bits in the dirty log mask

[Fam Zheng]

On Mon, 04/27 18:28, Paolo Bonzini wrote:
> When the dirty log mask will also cover other bits than DIRTY_MEMORY_VGA,
> some listeners may be interested in the overall zero/non-zero value of
> the dirty log mask; others may be interested in the value of single bits.
> 
> For this reason, always call log_start/log_stop if bits have respectively
> appeared or disappeared, and pass the old and new values of the dirty log
> mask so that listeners can distinguish the kinds of change.
> 
> For example, KVM checks if dirty logging used to be completely disabled
> (in log_start) or is now completely disabled (in log_stop).  On the
> other hand, Xen has to check manually if DIRTY_MEMORY_VGA changed,
> since that is the only bit it cares about.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Fam Zheng <address@hidden>