[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/29] display: add memory_region_sync_dirty_bit
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/29] display: add memory_region_sync_dirty_bitmap calls |
|
Date: |
Tue, 26 May 2015 10:14:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 26/05/2015 09:36, Fam Zheng wrote:
> On Mon, 04/27 18:28, Paolo Bonzini wrote:
>> diff --git a/hw/display/tcx.c b/hw/display/tcx.c
>> index 58faa96..2eb5aef 100644
>> --- a/hw/display/tcx.c
>> +++ b/hw/display/tcx.c
>> @@ -353,6 +353,7 @@ static void tcx_update_display(void *opaque)
>> return;
>> }
>>
>> + memory_region_sync_dirty_bitmap(&ts->vram_mem);
>> for (y = 0; y < ts->height; page += TARGET_PAGE_SIZE) {
>> if (memory_region_get_dirty(&ts->vram_mem, page, TARGET_PAGE_SIZE,
>> DIRTY_MEMORY_VGA)) {
>
> Why not change tcx24_update_display as well?
You're right.
Paolo