Re: [Qemu-devel] [PATCH 11/29] memory: include DIRTY_MEMORY_MIGRATION in the dirty log mask

[Fam Zheng]

On Tue, 05/26 11:07, Paolo Bonzini wrote:
> 
> 
> On 26/05/2015 10:40, Fam Zheng wrote:
> > > @@ -1329,7 +1329,11 @@ bool memory_region_is_skip_dump(MemoryRegion *mr)
> > >  
> > >  uint8_t memory_region_get_dirty_log_mask(MemoryRegion *mr)
> > >  {
> > > -    return mr->dirty_log_mask;
> > > +    uint8_t mask = mr->dirty_log_mask;
> > > +    if (global_dirty_log) {
> > > +        mask |= (1 << DIRTY_MEMORY_MIGRATION);
> > 
> > This is ugly, but I don't know how to do differently. :(
> 
> Why do you think it's ugly?
> As long as the log_start/log_stop callbacks
> are handled properly, I think it's okay.

Ugly in the per object function relying on a global to propogate the new value.

Fam