Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI

[Daniel P. Berrange]

On Tue, May 26, 2015 at 02:51:45PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > >> +#
> > >> +# Set the spice/vnc connection info for the migration target.  The
> > >> +# spice/vnc server will ask the spice/vnc client to automatically
> > >> +# reconnect using the new parameters (if specified) once the vm
> > >> +# migration finished successfully.  Not yet implemented for VNC.
> > >> +#
> > >> +# @protocol:     must be "spice"
> > >> +# @hostname:     migration target hostname
> > >> +# @port:         #optional spice/vnc tcp port for plaintext channels
> > >
> > > Is it worth documenting vnc, when we just stated earlier that protocol
> > > must be spice?
> > 
> > I think this is a question for Gerd (cc'ed).
> 
> IIRC Daniel (added to Cc:) had plans to create a vnc extension for that.
> 
> Which was the reason to explicitly add the protocol here, so we can use
> the same command for both spice and vnc some day.

Yeah, it would be nice to do a VNC extension, though realistically I'm
not going to have time for that anytime in the forseeable future.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|