[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map |
Date: |
Wed, 27 May 2015 12:40:25 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, May 26, 2015 at 03:58:05PM +0200, Gerd Hoffmann wrote:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11. This patch gets the two keys going with the gtk and sdl1 UIs.
>
> With vnc (remote-viewer) only one of the two works correctly.
> Probably a client-side issue. Not investigated in detail though.
The gtk-vnc keymaps.csv file has entries for both these key codes.
For EVDEV_RO it maps to XT KBD code 115 (0x73 in decimal) which matches
your patch.
For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
does not match your patch. I'm not sure where I got that mapping
from originally - probably from the Linux kernel's XT <-> evdev
keymapping tables.
So presumably you were finding the KPCOMMA one was broken in
remote-viewer ? It'll be broken in SPICE too, since that shares
the same keymaps.csv file
> static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> - 0, /* 97 EVDEV - RO ("Internet" Keyboards) */
> + 0x73, /* 97 EVDEV - RO ("Internet" Keyboards) */
> 0, /* 98 EVDEV - KATA (Katakana) */
> 0, /* 99 EVDEV - HIRA (Hiragana) */
> 0x79, /* 100 EVDEV - HENK (Henkan) */
> @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> 0, /* 126 EVDEV - I126 ("Internet" Keyboards) */
> 0, /* 127 EVDEV - PAUS */
> 0, /* 128 EVDEV - ???? */
> - 0, /* 129 EVDEV - I129 ("Internet" Keyboards) */
> + 0xf0, /* 129 EVDEV - I129 ("Internet" Keyboards) */
> 0xf1, /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
> 0xf2, /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
> 0x7d, /* 132 AE13 (Yen)*/
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|