Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts

[Richard W.M. Jones]

On Wed, May 27, 2015 at 02:45:29PM +0200, Paolo Bonzini wrote:
> 
> 
> On 27/05/2015 14:41, Richard W.M. Jones wrote:
> >> > -                if (watchdog) {
> >> > -                    fprintf(stderr,
> >> > -                            "qemu: only one watchdog option may be 
> >> > given\n");
> >> > -                    return 1;
> >> > +                olist = qemu_find_opts("watchdog");
> >> > +                opts = qemu_opts_parse(olist, optarg, 1);
> >> > +                if (!opts) {
> >> > +                    exit(1);
> >> >                  }
> > Is there an error message missing (before the call to exit)?
> 
> Oh, I forgot to answer this.  Any error message is printed by
> qemu_opts_parse, for example:
> 
> $ x86_64-softmmu/qemu-system-x86_64 -watchdog foo=bar
> qemu-system-x86_64: -watchdog foo=bar: Invalid parameter 'foo'

Patch seems fine then, ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org