[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 7/8] qemu-iotests: Add test case for mirror w
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v6 7/8] qemu-iotests: Add test case for mirror with unmap |
Date: |
Thu, 28 May 2015 10:29:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 28/05/2015 07:29, Fam Zheng wrote:
> This checks that the discard on mirror source that effectively zeroes
> data is also reflected by the data of target.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/132 | 59
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/132.out | 5 ++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 65 insertions(+)
> create mode 100644 tests/qemu-iotests/132
> create mode 100644 tests/qemu-iotests/132.out
>
> diff --git a/tests/qemu-iotests/132 b/tests/qemu-iotests/132
> new file mode 100644
> index 0000000..f53ef6e
> --- /dev/null
> +++ b/tests/qemu-iotests/132
> @@ -0,0 +1,59 @@
> +#!/usr/bin/env python
> +#
> +# Test mirror with unmap
> +#
> +# Copyright (C) 2015 Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +import time
> +import os
> +import iotests
> +from iotests import qemu_img, qemu_io
> +
> +test_img = os.path.join(iotests.test_dir, 'test.img')
> +target_img = os.path.join(iotests.test_dir, 'target.img')
> +
> +class TestSingleDrive(iotests.QMPTestCase):
> + image_len = 2 * 1024 * 1024 # MB
> +
> + def setUp(self):
> + # Write data to the image so we can compare later
> + qemu_img('create', '-f', iotests.imgfmt, test_img,
> str(TestSingleDrive.image_len))
> + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 0 2M', test_img)
> +
> + self.vm = iotests.VM().add_drive(test_img, 'discard=unmap')
> + self.vm.launch()
> +
> + def tearDown(self):
> + self.vm.shutdown()
> + os.remove(test_img)
> + try:
> + os.remove(target_img)
> + except OSError:
> + pass
> +
> + def test_mirror_discard(self):
> + result = self.vm.qmp('drive-mirror', device='drive0', sync='full',
> + target=target_img)
> + self.assert_qmp(result, 'return', {})
> + self.vm.hmp_qemu_io('drive0', 'discard 0 64k')
> + self.complete_and_wait('drive0')
> + self.vm.shutdown()
> + self.assertTrue(iotests.compare_images(test_img, target_img),
> + 'target image does not match source after mirroring')
> +
> +if __name__ == '__main__':
> + iotests.main(supported_fmts=['raw', 'qcow2'])
> diff --git a/tests/qemu-iotests/132.out b/tests/qemu-iotests/132.out
> new file mode 100644
> index 0000000..ae1213e
> --- /dev/null
> +++ b/tests/qemu-iotests/132.out
> @@ -0,0 +1,5 @@
> +.
> +----------------------------------------------------------------------
> +Ran 1 tests
> +
> +OK
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 0b817ca..757ac1b 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -129,4 +129,5 @@
> 129 rw auto quick
> 130 rw auto quick
> 131 rw auto quick
> +132 rw auto quick
> 134 rw auto quick
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH v6 1/8] block: Add bdrv_get_block_status_above, (continued)
- [Qemu-devel] [PATCH v6 1/8] block: Add bdrv_get_block_status_above, Fam Zheng, 2015/05/28
- [Qemu-devel] [PATCH v6 2/8] qmp: Add optional bool "unmap" to drive-mirror, Fam Zheng, 2015/05/28
- [Qemu-devel] [PATCH v6 3/8] mirror: Do zero write on target if sectors not allocated, Fam Zheng, 2015/05/28
- [Qemu-devel] [PATCH v6 4/8] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/05/28
- [Qemu-devel] [PATCH v6 5/8] block: Remove bdrv_reset_dirty, Fam Zheng, 2015/05/28
- [Qemu-devel] [PATCH v6 6/8] qemu-iotests: Make block job methods common, Fam Zheng, 2015/05/28
- [Qemu-devel] [PATCH v6 7/8] qemu-iotests: Add test case for mirror with unmap, Fam Zheng, 2015/05/28
- Re: [Qemu-devel] [PATCH v6 7/8] qemu-iotests: Add test case for mirror with unmap,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v6 8/8] iotests: Use event_wait in wait_ready, Fam Zheng, 2015/05/28