[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither it nor
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted |
|
Date: |
Thu, 28 May 2015 10:42:05 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 28/05/2015 10:39, Markus Armbruster wrote:
> > - pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> > + pc_basic_device_init(isa_bus, gsi, &rtc_state, force_fdctrl, &floppy,
> > (pc_machine->vmport != ON_OFF_AUTO_ON), 0xff0104);
> >
> > /* connect pm stuff to lpc */
>
> If we can get from MachineState *machine to its MachineClass,
Sure you can, it's just MACHINE_GET_CLASS(machine).
Paolo
> we could
> use MachineClass member no_floppy, and not need force_fdctrl. Probably
> a wash.