Re: [Qemu-devel] [PATCH RFC v2 0/1] virtio: host features in vdev

[Michael S. Tsirkin]

On Tue, May 26, 2015 at 04:34:46PM +0200, Cornelia Huck wrote:
> Next version of the patch moving the host features from the transports
> into the vdev. I have not yet tested migration (probably ok, though),
> but the rest should be fine.
> 
> I'll try to see how the feature bit changes for virtio-1 work out on
> top of this.
> 
> v1->v2: remove host features from virtio-pci and s390-virtio transport
>         proxies [Shannon Zhao]
> 
> Cornelia Huck (1):
>   virtio: move host_features
> 
>  hw/s390x/s390-virtio-bus.c     | 18 ++----------------
>  hw/s390x/s390-virtio-bus.h     |  1 -
>  hw/s390x/virtio-ccw.c          | 29 ++++++-----------------------
>  hw/s390x/virtio-ccw.h          |  4 ----
>  hw/virtio/virtio-bus.c         | 18 +++++-------------
>  hw/virtio/virtio-mmio.c        | 22 +++-------------------
>  hw/virtio/virtio-pci.c         | 17 ++++-------------
>  hw/virtio/virtio-pci.h         |  1 -
>  hw/virtio/virtio.c             | 17 +++++++++--------
>  include/hw/virtio/virtio-bus.h |  1 -
>  include/hw/virtio/virtio.h     |  1 +
>  11 files changed, 30 insertions(+), 99 deletions(-)

I like the diffstat!
Don't see anything wrong here, though a couple more cleanups
are possible on top.

> -- 
> 2.3.7