Re: [Qemu-devel] [PATCH v3 6/6] target-microblaze: Disable stack protection by default

[Edgar E. Iglesias]

On Fri, May 29, 2015 at 04:32:35PM +1000, Alistair Francis wrote:
> Stack protection is not available when the MMU is enabled.
> As the MMU is enabled by default, disable stack protection
> by default.
> 
> Signed-off-by: Alistair Francis <address@hidden>


Reviewed-by: Edgar E. Iglesias <address@hidden>


> ---
> 
>  target-microblaze/cpu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index b857056..13ae49a 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -162,7 +162,7 @@ static const VMStateDescription vmstate_mb_cpu = {
>  static Property mb_properties[] = {
>      DEFINE_PROP_UINT32("base-vectors", MicroBlazeCPU, cfg.base_vectors, 0),
>      DEFINE_PROP_BOOL("use-stack-protection", MicroBlazeCPU, cfg.stackprot,
> -                     true),
> +                     false),
>      /* If use-fpu > 0 - FPU is enabled
>       * If use-fpu = 2 - Floating point conversion and square root 
> instructions
>       *                  are enabled
> -- 
> 1.7.1
>