Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Tue, 26 May 2015 17:20:35 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Command handlers still use QError.  Left for another day.
>
> Great work! I've found one bug that has to be addressed before merging.
> Also, for the error conversions you're doing you're going from
> qerror_report() to error_set() but I'd recommend going directly to
> error_setg() as that's our final goal. It's totally fine with me
> if you're saving this work for a later series, but I think it will
> you save work if you do it in this series. Your call.

Saving for later, not least because this series has been fully reviewed
now.

> Can you take this through your tree?

Sure!

>                                      Feel free to add this once
> you fix the bug:
>
> Reviewed-by: Luiz Capitulino <address@hidden>

Thanks!