[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/8] throttle: acquire the ThrottleGroup lock in
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 5/8] throttle: acquire the ThrottleGroup lock in bdrv_swap() |
Date: |
Fri, 29 May 2015 13:33:21 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, May 19, 2015 at 03:24:33PM +0300, Alberto Garcia wrote:
> bdrv_swap() touches the fields of a BlockDriverState that are
> protected by the ThrottleGroup lock. Although those fields end up in
> their original place, they are temporarily swapped in the process,
> so there's a chance that an operation on a member of the same group
> happening on a different thread can try to use them.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block.c | 16 ++++++++++++++++
> block/throttle-groups.c | 31 ++++++++++++++++++++++++++++++-
> include/block/throttle-groups.h | 3 +++
> 3 files changed, 49 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpZm78aTAL1b.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v8 0/8] Block Throttle Group Support, Alberto Garcia, 2015/05/19
- [Qemu-devel] [PATCH 7/8] throttle: Update throttle infrastructure copyright, Alberto Garcia, 2015/05/19
- [Qemu-devel] [PATCH 3/8] throttle: Add throttle group infrastructure tests, Alberto Garcia, 2015/05/19
- [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling, Alberto Garcia, 2015/05/19
- [Qemu-devel] [PATCH 6/8] throttle: add the name of the ThrottleGroup to BlockDeviceInfo, Alberto Garcia, 2015/05/19
- [Qemu-devel] [PATCH 5/8] throttle: acquire the ThrottleGroup lock in bdrv_swap(), Alberto Garcia, 2015/05/19
- Re: [Qemu-devel] [PATCH 5/8] throttle: acquire the ThrottleGroup lock in bdrv_swap(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/8] throttle: Add throttle group infrastructure, Alberto Garcia, 2015/05/19
- [Qemu-devel] [PATCH 4/8] throttle: Add throttle group support, Alberto Garcia, 2015/05/19
- [Qemu-devel] [PATCH 1/8] throttle: Extract timers from ThrottleState into a separate structure, Alberto Garcia, 2015/05/19