Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

[Kevin Wolf]

Am 29.05.2015 um 13:22 hat Markus Armbruster geschrieben:
> Kevin Wolf <address@hidden> writes:
> 
> > Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben:
> >> Touches vl.c, which gives me pretext to ask Paolo: would you be
> >> willing to take this through your tree?  Or should I take it through
> >> mine?
> >
> > After this series we have an ugly half-converted state where
> > qemu_opts_foreach() has both a return code and an Error object,
> > and it's not generally true that an error is set for a failing
> > return code.
> >
> > The most confusing part about this is that you have &error_abort almost
> > everywhere, but the function doesn't actually abort on error, but rather
> > returns a negative error code and leaves errp alone.
> 
> True.  The function contract spells it out, which hopefully reduces the
> confusion somewhat.
> 
> Would you find NULL less confusing than &error_abort?

That might be better, yes. At least it doesn't imply that no errors can
happen, just that we don't handle them. In places that actually do
handle errors using the return code even though passing a NULL errp, that
is obvious and doesn't lead to assumptions about the called function.

> > If you don't want to complete the conversion, can we add it to that wiki
> > page with the list half-done conversions at least?
> 
> Can do.
> 
> "That wiki page" = http://wiki.qemu.org/CodeTransitions

Yes, that's the one I meant. Thanks.

Kevin