[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20 |
|
Date: |
Fri, 29 May 2015 15:14:53 +0100 |
[apologies for getting David G's email address wrong first time round]
On 29 May 2015 at 15:08, Daniel P. Berrange <address@hidden> wrote:
> On Fri, May 29, 2015 at 02:57:12PM +0100, Peter Maydell wrote:
>> On 29 May 2015 at 14:51, Daniel P. Berrange <address@hidden> wrote:
>> > Since that caused failure with glib 2.22 could you revert that switch
>> > to g_assert_null/nonnull.
>>
>> BTW, David Gilbert is looking at whether we can use the glib support
>> to make use of "newer than version X" APIs a compile error everywhere
>> rather than just on boxes with the older glib, which should help
>> cut down on this kind of problem in future.
>
> It seem these g_assert_nonnull/null functions are in fact just trivial
> macros, so we could alternatively add them to our glib-compat.h file
Well, we could, but I don't really see the point compared to
just using g_assert()...
-- PMM
- [Qemu-devel] [PULL 09/12] qom: Add object_new_with_props() / object_new_withpropv() helpers, (continued)
- [Qemu-devel] [PULL 09/12] qom: Add object_new_with_props() / object_new_withpropv() helpers, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 03/12] tests: Use qtest_add_data_func() consistently, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 06/12] doc: Document user creatable object types in help text, Andreas Färber, 2015/05/20
- [Qemu-devel] [PULL 07/12] vl: Create (most) objects before creating chardev backends, Andreas Färber, 2015/05/20
- Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20, Peter Maydell, 2015/05/21