[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command h
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers |
Date: |
Fri, 29 May 2015 10:27:11 -0400 |
On Fri, 29 May 2015 16:23:55 +0200
Markus Armbruster <address@hidden> wrote:
> The following hunk needs to be squashed in:
>
> diff --git a/monitor.c b/monitor.c
> index 16bd567..888d771 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -5005,7 +5005,6 @@ static void handle_qmp_command(JSONMessageParser
> *parser, QList *tokens)
> goto err_out;
> }
> if (invalid_qmp_mode(mon, cmd, &local_err)) {
> - qerror_report_err(local_err);
> goto err_out;
> }
Reviewed-by: Luiz Capitulino <address@hidden>
>
>
- [Qemu-devel] [PATCH v3 08/21] monitor: Drop unused "new" HMP command interface, (continued)
- [Qemu-devel] [PATCH v3 08/21] monitor: Drop unused "new" HMP command interface, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 12/21] monitor: Wean monitor_protocol_emitter() off mon->error, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 06/21] monitor: Use traditional command interface for HMP device_add, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode(), Markus Armbruster, 2015/05/29
- Re: [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode(), Eric Blake, 2015/05/29
- [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 15/21] monitor: Rename handle_user_command() to handle_hmp_command(), Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 18/21] monitor: Drop do_qmp_capabilities()'s superfluous QMP check, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 07/21] monitor: Use trad. command interface for HMP pcie_aer_inject_error, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 04/21] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 09/21] monitor: Propagate errors through qmp_check_client_args(), Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 21/21] monitor: Change return type of monitor_cur_is_qmp() to bool, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 01/21] monitor: Drop broken, unused asynchronous command interface, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 16/21] monitor: Rename monitor_control_read(), monitor_control_event(), Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 17/21] monitor: Unbox Monitor member mc and rename to qmp, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 19/21] monitor: Turn int command_mode into bool in_command_mode, Markus Armbruster, 2015/05/29