[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/5] apic: convert ->busdev.qdev casts to C casts
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 3/5] apic: convert ->busdev.qdev casts to C casts |
Date: |
Fri, 29 May 2015 15:04:22 -0300 |
From: Zhu Guihua <address@hidden>
Use C casts to avoid accessing ICCDevice's qdev field
directly.
Signed-off-by: Zhu Guihua <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Acked-by: Andreas Färber <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/intc/apic.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index 0f97b47..77b639c 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@ -370,13 +370,14 @@ static int apic_irq_pending(APICCommonState *s)
static void apic_update_irq(APICCommonState *s)
{
CPUState *cpu;
+ DeviceState *dev = (DeviceState *)s;
cpu = CPU(s->cpu);
if (!qemu_cpu_is_self(cpu)) {
cpu_interrupt(cpu, CPU_INTERRUPT_POLL);
} else if (apic_irq_pending(s) > 0) {
cpu_interrupt(cpu, CPU_INTERRUPT_HARD);
- } else if (!apic_accept_pic_intr(&s->busdev.qdev) ||
!pic_get_output(isa_pic)) {
+ } else if (!apic_accept_pic_intr(dev) || !pic_get_output(isa_pic)) {
cpu_reset_interrupt(cpu, CPU_INTERRUPT_HARD);
}
}
@@ -549,10 +550,12 @@ static void apic_deliver(DeviceState *dev, uint8_t dest,
uint8_t dest_mode,
static bool apic_check_pic(APICCommonState *s)
{
- if (!apic_accept_pic_intr(&s->busdev.qdev) || !pic_get_output(isa_pic)) {
+ DeviceState *dev = (DeviceState *)s;
+
+ if (!apic_accept_pic_intr(dev) || !pic_get_output(isa_pic)) {
return false;
}
- apic_deliver_pic_intr(&s->busdev.qdev, 1);
+ apic_deliver_pic_intr(dev, 1);
return true;
}
--
2.1.0
- [Qemu-devel] [PULL 0/5] X86 patch queue, 2015-05-29, Eduardo Habkost, 2015/05/29
- [Qemu-devel] [PULL 1/5] pc: Ensure non-zero CPU ref count after attaching to ICC bus, Eduardo Habkost, 2015/05/29
- [Qemu-devel] [PULL 2/5] apic: map APIC's MMIO region at each CPU's address space, Eduardo Habkost, 2015/05/29
- [Qemu-devel] [PULL 3/5] apic: convert ->busdev.qdev casts to C casts,
Eduardo Habkost <=
- [Qemu-devel] [PULL 4/5] target-i386: Register QOM properties for feature flags, Eduardo Habkost, 2015/05/29
- [Qemu-devel] [PULL 5/5] arch_init: Drop target-x86_64.conf, Eduardo Habkost, 2015/05/29
- Re: [Qemu-devel] [PULL 0/5] X86 patch queue, 2015-05-29, Peter Maydell, 2015/05/29