Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

[Peter Maydell]

On 29 May 2015 at 20:16, Martin Galvan
<address@hidden> wrote:
> On Fri, May 29, 2015 at 4:15 PM, Liviu Ionescu <address@hidden> wrote:
>> this is fine with me.
>>
>> unfortunately I cannot review your patch, since I have not enough experience 
>> with that part of qemu.
>
> I think Peter M is the maintainer for Target-ARM.
>
> Peter, is this OK to commit?

The patch is on my to-review queue; unfortunately I'm quite
heavily loaded with patches to review at the moment, so it
may be a week or so before I can get to this one in detail.
Sorry about that.

At a quick glance it looks broadly OK. Personally I prefer
hoisting the "UNDEF if feature missing" checks earlier in the
decode function rather than having them later and having to
do manual tcg_temp_free operations, but this isn't always
feasible with the existing structure of the code.

I might also split it into two patches: one which just
adds and implements the new feature bit, and then one
which creates the new M4 CPU. (That way if it turns out
that we need to make other changes for the M4 before
we can enable it, the first patch can still be reviewed
and possibly committed even if we have to wait before
putting in the new CPU itself.)

thanks
-- PMM